Skip to content

fix: remove sortChanges util #599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
avivkeller merged 2 commits into from
Feb 11, 2026
Merged

fix: remove sortChanges util #599

avivkeller merged 2 commits into from
Feb 11, 2026
+5 −63

Conversation

@aduh95
Copy link
Contributor

@aduh95 aduh95 commented Feb 10, 2026

Description

We should respect the order defined in the markdown document, and let the linter enforces a specific order.

Validation

Related Issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run node --run test and all tests passed.
  • I have check code formatting with node --run format & node --run lint.
  • I've covered new added functionality with unit tests if necessary.

@aduh95 aduh95 requested a review from a team as a code owner February 10, 2026 21:42
Copilot AI review requested due to automatic review settings February 10, 2026 21:42
@vercel
Copy link

vercel bot commented Feb 10, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
api-docs-tooling Ready Ready Preview Feb 10, 2026 9:46pm

Request Review

@aduh95 aduh95 review requested due to automatic review settings February 10, 2026 21:43
@codecov
Copy link

codecov bot commented Feb 10, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 80.52%. Comparing base (6ec9047) to head (ef07b8b).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/generators/jsx-ast/utils/buildContent.mjs 66.66% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #599      +/-   ##
==========================================
- Coverage   80.59%   80.52%   -0.07%     
==========================================
  Files         126      126              
  Lines       12134    12076      -58     
  Branches      874      867       -7     
==========================================
- Hits         9779     9724      -55     
+ Misses       2352     2349       -3     
  Partials        3        3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link

github-actions bot commented Feb 10, 2026 •
edited
Loading

api-links Generator

apilinks.json 
Expected values to be strictly deep-equal:
+ actual - expected
... Skipped lines

  {
    'Agent.defaultMaxSockets': 'https://github.com/nodejs/node/tree/HEAD/lib/_http_agent.js#L227',
    'Buffer.alloc': 'https://github.com/nodejs/node/tree/HEAD/lib/buffer.js#L431',
    'Buffer.allocUnsafe': 'https://github.com/nodejs/node/tree/HEAD/lib/buffer.js#L445',
    'Buffer.allocUnsafeSlow': 'https://github.com/nodejs/node/tree/HEAD/lib/buffer.js#L457',
...
    'agent.addRequest': 'https://github.com/nodejs/node/tree/HEAD/lib/_http_agent.js#L292',
+   'agent.createConnection': 'https://github.com/nodejs/node/tree/HEAD/lib/https.js#L326',
-   'agent.createConnection': 'https://github.com/nodejs/node/tree/HEAD/lib/_http_agent.js#L231',
    'agent.createSocket': 'https://github.com/nodejs/node/tree/HEAD/lib/_http_agent.js#L363',
    'agent.destroy': 'https://github.com/nodejs/node/tree/HEAD/lib/_http_agent.js#L595',
+   'agent.getName': 'https://github.com/nodejs/node/tree/HEAD/lib/https.js#L484',
-   'agent.getName': 'https://github.com/nodejs/node/tree/HEAD/lib/_http_agent.js#L261',
    'agent.keepSocketAlive': 'https://github.com/nodejs/node/tree/HEAD/lib/_http_agent.js#L552',
    'agent.removeSocket': 'https://github.com/nodejs/node/tree/HEAD/lib/_http_agent.js#L491',
    'agent.reuseSocket': 'https://github.com/nodejs/node/tree/HEAD/lib/_http_agent.js#L588',
    'assert.assert': 'https://github.com/nodejs/node/tree/HEAD/lib/assert.js#L185',
    'asyncResource.asyncId': 'https://github.com/nodejs/node/tree/HEAD/lib/async_hooks.js#L242',
...
    'server.address': 'https://github.com/nodejs/node/tree/HEAD/lib/net.js#L2297',
+   'server.close': 'https://github.com/nodejs/node/tree/HEAD/lib/net.js#L2430',
+   'server.closeAllConnections': 'https://github.com/nodejs/node/tree/HEAD/lib/https.js#L120',
+   'server.closeIdleConnections': 'https://github.com/nodejs/node/tree/HEAD/lib/https.js#L122',
-   'server.close': 'https://github.com/nodejs/node/tree/HEAD/lib/_http_server.js#L611',
-   'server.closeAllConnections': 'https://github.com/nodejs/node/tree/HEAD/lib/_http_server.js#L621',
-   'server.closeIdleConnections': 'https://github.com/nodejs/node/tree/HEAD/lib/_http_server.js#L633',
    'server.getConnections': 'https://github.com/nodejs/node/tree/HEAD/lib/net.js#L2392',
    'server.listen': 'https://github.com/nodejs/node/tree/HEAD/lib/net.js#L2114',
    'server.ref': 'https://github.com/nodejs/node/tree/HEAD/lib/net.js#L2535',
+   'server.setTimeout': 'https://github.com/nodejs/node/tree/HEAD/lib/https.js#L124',
-   'server.setTimeout': 'https://github.com/nodejs/node/tree/HEAD/lib/_http_server.js#L649',
    'server.unref': 'https://github.com/nodejs/node/tree/HEAD/lib/net.js#L2544',
+   'server[SymbolAsyncDispose]': 'https://github.com/nodejs/node/tree/HEAD/lib/net.js#L2470',
+   'server[undefined]': 'https://github.com/nodejs/node/tree/HEAD/lib/net.js#L2499',
-   'server[SymbolAsyncDispose]': 'https://github.com/nodejs/node/tree/HEAD/lib/_http_server.js#L617',
-   'server[undefined]': 'https://github.com/nodejs/node/tree/HEAD/lib/_http_server.js#L656',
    'serverresponse._finish': 'https://github.com/nodejs/node/tree/HEAD/lib/_http_server.js#L244',
    'serverresponse._implicitHeader': 'https://github.com/nodejs/node/tree/HEAD/lib/_http_server.js#L351',
    'serverresponse.assignSocket': 'https://github.com/nodejs/node/tree/HEAD/lib/_http_server.js#L294',
    'serverresponse.detachSocket': 'https://github.com/nodejs/node/tree/HEAD/lib/_http_server.js#L305',
    'serverresponse.statusCode': 'https://github.com/nodejs/node/tree/HEAD/lib/_http_server.js#L267',

legacy-json Generator

assert.json 
Expected values to be strictly deep-equal:
+ actual - expected
... Skipped lines

  {
    modules: [
      {
        classes: [
          {
...
                {
+                 'pr-url': 'https://github.com/nodejs/node/pull/58849',
+                 description: 'Message may now be a `printf`-like format string or function.',
+                 version: 'REPLACEME'
+               },
+               {
                  'pr-url': 'https://github.com/nodejs/node/pull/59448',
                  description: 'Promises are not considered equal anymore if they are not of the same instance.',
                  version: 'v25.0.0'
                },
                {
...
                },
-               {
-                 'pr-url': 'https://github.com/nodejs/node/pull/58849',
-                 description: 'Message may now be a `printf`-like format string or function.',
-                 version: 'REPLACEME'
-               }
              ]
            },
            modules: [
              {
                desc: '<ul>\n' +
...
                {
+                 'pr-url': 'https://github.com/nodejs/node/pull/58849',
+                 description: 'Message may now be a `printf`-like format string or function.',
+                 version: 'REPLACEME'
+               },
+               {
                  'pr-url': 'https://github.com/nodejs/node/pull/38111',
                  description: 'This API is no longer experimental.',
                  version: 'v16.0.0'
                },
-               {
-                 'pr-url': 'https://github.com/nodejs/node/pull/58849',
-                 description: 'Message may now be a `printf`-like format string or function.',
-                 version: 'REPLACEME'
-               }
              ]
            },
            name: 'doesNotMatch',
            signatures: [
              {
...
                {
+                 'pr-url': 'https://github.com/nodejs/node/pull/58849',
+                 description: 'Message may now be a `printf`-like format string or function.',
+                 version: 'REPLACEME'
+               },
+               {
                  'pr-url': 'https://github.com/nodejs/node/pull/38113',
                  description: 'In Legacy assertion mode, changed status from Deprecated to Legacy.',
                  version: [
                    'v16.0.0',
                    'v14.18.0'
...
                },
-               {
-                 'pr-url': 'https://github.com/nodejs/node/pull/58849',
-                 description: 'Message may now be a `printf`-like format string or function.',
-                 version: 'REPLACEME'
-               }
              ]
            },
            name: 'equal',
            signatures: [
              {
...
                {
+                 'pr-url': 'https://github.com/nodejs/node/pull/58849',
+                 description: 'Message may now be a `printf`-like format string or function.',
+                 version: 'REPLACEME'
+               },
+               {
                  'pr-url': 'https://github.com/nodejs/node/pull/38111',
                  description: 'This API is no longer experimental.',
                  version: 'v16.0.0'
                },
-               {
-                 'pr-url': 'https://github.com/nodejs/node/pull/58849',
-                 description: 'Message may now be a `printf`-like format string or function.',
-                 version: 'REPLACEME'
-               }
              ]
            },
            name: 'match',
            signatures: [
              {
...
                {
+                 'pr-url': 'https://github.com/nodejs/node/pull/58849',
+                 description: 'Message may now be a `printf`-like format string or function.',
+                 version: 'REPLACEME'
+               },
+               {
                  'pr-url': 'https://github.com/nodejs/node/pull/38113',
                  description: 'In Legacy assertion mode, changed status from Deprecated to Legacy.',
                  version: [
                    'v16.0.0',
                    'v14.18.0'
...
                },
-               {
-                 'pr-url': 'https://github.com/nodejs/node/pull/58849',
-                 description: 'Message may now be a `printf`-like format string or function.',
-                 version: 'REPLACEME'
-               }
              ]
            },
            name: 'notDeepEqual',
            signatures: [
              {
...
                {
+                 'pr-url': 'https://github.com/nodejs/node/pull/58849',
+                 description: 'Message may now be a `printf`-like format string or function.',
+                 version: 'REPLACEME'
+               },
+               {
                  'pr-url': 'https://github.com/nodejs/node/pull/15398',
                  description: 'The `-0` and `+0` are not considered equal anymore.',
                  version: 'v9.0.0'
                },
                {
...
                },
-               {
-                 'pr-url': 'https://github.com/nodejs/node/pull/58849',
-                 description: 'Message may now be a `printf`-like format string or function.',
-                 version: 'REPLACEME'
-               }
              ]
            },
            name: 'notDeepStrictEqual',
            signatures: [
              {
...
                {
+                 'pr-url': 'https://github.com/nodejs/node/pull/58849',
+                 description: 'Message may now be a `printf`-like format string or function.',
+                 version: 'REPLACEME'
+               },
+               {
                  'pr-url': 'https://github.com/nodejs/node/pull/38113',
                  description: 'In Legacy assertion mode, changed status from Deprecated to Legacy.',
                  version: [
                    'v16.0.0',
                    'v14.18.0'
...
                },
-               {
-                 'pr-url': 'https://github.com/nodejs/node/pull/58849',
-                 description: 'Message may now be a `printf`-like format string or function.',
-                 version: 'REPLACEME'
-               }
              ]
            },
            name: 'notEqual',
            signatures: [
              {
...
                {
+                 'pr-url': 'https://github.com/nodejs/node/pull/58849',
+                 description: 'Message may now be a `printf`-like format string or function.',
+                 version: 'REPLACEME'
+               },
+               {
                  'pr-url': 'https://github.com/nodejs/node/pull/17003',
                  description: 'Used comparison changed from Strict Equality to `Object.is()`.',
                  version: 'v10.0.0'
                },
-               {
-                 'pr-url': 'https://github.com/nodejs/node/pull/58849',
-                 description: 'Message may now be a `printf`-like format string or function.',
-                 version: 'REPLACEME'
-               }
              ]
            },
            name: 'notStrictEqual',
            signatures: [
              {
...
                {
+                 'pr-url': 'https://github.com/nodejs/node/pull/58849',
+                 description: 'Message may now be a `printf`-like format string or function.',
+                 version: 'REPLACEME'
+               },
+               {
                  'pr-url': 'https://github.com/nodejs/node/pull/18319',
                  description: 'The `assert.ok()` (no arguments) will now use a predefined error message.',
                  version: 'v10.0.0'
                },
-               {
-                 'pr-url': 'https://github.com/nodejs/node/pull/58849',
-                 description: 'Message may now be a `printf`-like format string or function.',
-                 version: 'REPLACEME'
-               }
              ]
            },
            name: 'ok',
            signatures: [
              {
...
                {
+                 'pr-url': 'https://github.com/nodejs/node/pull/58849',
+                 description: 'Message may now be a `printf`-like format string or function.',
+                 version: 'REPLACEME'
+               },
+               {
                  'pr-url': 'https://github.com/nodejs/node/pull/17003',
                  description: 'Used comparison changed from Strict Equality to `Object.is()`.',
                  version: 'v10.0.0'
                },
-               {
-                 'pr-url': 'https://github.com/nodejs/node/pull/58849',
-                 description: 'Message may now be a `printf`-like format string or function.',
-                 version: 'REPLACEME'
-               }
              ]
            },
            name: 'strictEqual',
            signatures: [
              {
crypto.json 
Expected values to be strictly deep-equal:
+ actual - expected
... Skipped lines

  {
    modules: [
      {
        classes: [
          {
...
                    {
+                     'pr-url': 'https://github.com/nodejs/node/pull/61084',
+                     description: 'Using GCM tag lengths other than 128 bits without specifying the `authTagLength` option when creating `decipher` is not allowed anymore.',
+                     version: 'REPLACEME'
+                   },
+                   {
                      'pr-url': 'https://github.com/nodejs/node/pull/52345',
                      description: 'Using GCM tag lengths other than 128 bits without specifying the `authTagLength` option when creating `decipher` is deprecated.',
                      version: [
                        'v22.0.0',
                        'v20.13.0'
...
                    },
-                   {
-                     'pr-url': 'https://github.com/nodejs/node/pull/61084',
-                     description: 'Using GCM tag lengths other than 128 bits without specifying the `authTagLength` option when creating `decipher` is not allowed anymore.',
-                     version: 'REPLACEME'
-                   }
                  ]
                },
                name: 'setAuthTag',
                signatures: [
                  {
deprecations.json 
Expected values to be strictly deep-equal:
+ actual - expected
... Skipped lines

  {
    introduced_in: 'v7.7.0',
    miscs: [
      {
        desc: '<p>Node.js APIs might be deprecated for any of the following reasons:</p>\n' +
...
                    {
+                     'pr-url': 'https://github.com/nodejs/node/pull/60635',
+                     description: 'End-of-Life.',
+                     version: 'REPLACEME'
+                   },
+                   {
                      'pr-url': 'https://github.com/nodejs/node/pull/59060',
                      description: 'Runtime deprecation.',
                      version: 'v25.0.0'
                    },
                    {
...
                    },
-                   {
-                     'pr-url': 'https://github.com/nodejs/node/pull/60635',
-                     description: 'End-of-Life.',
-                     version: 'REPLACEME'
-                   }
                  ]
                },
                name: 'dep0063:_`serverresponse.prototype.writeheader()`',
                textRaw: 'DEP0063: `ServerResponse.prototype.writeHeader()`',
                type: 'module'
...
                    {
+                     'pr-url': 'https://github.com/nodejs/node/pull/60657',
+                     description: 'End-of-Life.',
+                     version: 'REPLACEME'
+                   },
+                   {
                      'pr-url': 'https://github.com/nodejs/node/pull/26245',
                      description: 'Runtime deprecation.',
                      version: 'v12.0.0'
                    },
-                   {
-                     'pr-url': 'https://github.com/nodejs/node/pull/60657',
-                     description: 'End-of-Life.',
-                     version: 'REPLACEME'
-                   }
                  ]
                },
                name: "dep0125:_`require('node:_stream_wrap')`",
                textRaw: "DEP0125: `require('node:_stream_wrap')`",
                type: 'module'
...
                    {
+                     'pr-url': 'https://github.com/nodejs/node/pull/61084',
+                     description: 'End-of-Life.',
+                     version: 'REPLACEME'
+                   },
+                   {
                      'pr-url': 'https://github.com/nodejs/node/pull/52552',
                      description: 'Runtime deprecation.',
                      version: 'v23.0.0'
                    },
                    {
...
                    },
-                   {
-                     'pr-url': 'https://github.com/nodejs/node/pull/61084',
-                     description: 'End-of-Life.',
-                     version: 'REPLACEME'
-                   }
                  ]
                },
                name: 'dep0182:_short_gcm_authentication_tags_without_explicit_`authtaglength`',
                textRaw: 'DEP0182: Short GCM authentication tags without explicit `authTagLength`',
                type: 'module'
...
                    {
+                     'pr-url': 'https://github.com/nodejs/node/pull/60657',
+                     description: 'End-of-Life.',
+                     version: 'REPLACEME'
+                   },
+                   {
                      'pr-url': 'https://github.com/nodejs/node/pull/58337',
                      description: 'Runtime deprecation.',
                      version: [
                        'v24.2.0',
                        'v22.17.0',
...
                    },
-                   {
-                     'pr-url': 'https://github.com/nodejs/node/pull/60657',
-                     description: 'End-of-Life.',
-                     version: 'REPLACEME'
-                   }
                  ]
                },
                name: "dep0193:_`require('node:_stream_*')`",
                textRaw: "DEP0193: `require('node:_stream_*')`",
                type: 'module'
globals.json 
Expected values to be strictly deep-equal:
+ actual - expected
... Skipped lines

  {
    classes: [
      {
        classes: [
          {
...
                {
+                 'pr-url': 'https://github.com/nodejs/node/pull/60351',
+                 description: 'Accessing the `localStorage` global without providing `--localstorage-file` now throws a `DOMException`, for compliance with the Web Storage specification.',
+                 version: 'REPLACEME'
+               },
+               {
                  'pr-url': 'https://github.com/nodejs/node/pull/57666',
                  description: 'When webstorage is enabled and `--localstorage-file` is not provided, accessing the `localStorage` global now returns an empty object.',
                  version: 'v25.0.0'
                },
                {
...
                },
-               {
-                 'pr-url': 'https://github.com/nodejs/node/pull/60351',
-                 description: 'Accessing the `localStorage` global without providing `--localstorage-file` now throws a `DOMException`, for compliance with the Web Storage specification.',
-                 version: 'REPLACEME'
-               }
              ]
            },
            name: '`localstorage`',
            stability: 1.2,
            stabilityText: 'Release candidate. Disable this API with `--no-experimental-webstorage`.',
http.json 
Expected values to be strictly deep-equal:
+ actual - expected
... Skipped lines

  {
    modules: [
      {
        classes: [
          {
...
                    {
+                     'pr-url': 'https://github.com/nodejs/node/pull/60016',
+                     description: "Request bodies are no longer exposed raw (unparsed) on the socket argument. Instead, if a body is received, the stream argument will be a duplex that emits socket content only after the request body, while the parsed request body data will be emitted from the request, just as in normal server `'request'` events.",
+                     version: 'REPLACEME'
+                   },
+                   {
                      'pr-url': 'https://github.com/nodejs/node/pull/59824',
                      description: 'Whether this event is fired can now be controlled by the `shouldUpgradeCallback` and sockets will be destroyed if upgraded while no event handler is listening.',
                      version: [
                        'v24.9.0',
                        'v22.21.0'
...
                    },
-                   {
-                     'pr-url': 'https://github.com/nodejs/node/pull/60016',
-                     description: "Request bodies are no longer exposed raw (unparsed) on the socket argument. Instead, if a body is received, the stream argument will be a duplex that emits socket content only after the request body, while the parsed request body data will be emitted from the request, just as in normal server `'request'` events.",
-                     version: 'REPLACEME'
-                   }
                  ]
                },
                name: 'upgrade',
                params: [
                  {

orama-db Generator

File Base Head Diff
orama-db.json 8.03 MB 8.03 MB +2.00 B (+0.00%)

web Generator

File Base Head Diff
styles.css 125.95 KB 125.88 KB -67.00 B (-0.05%)

Copilot AI review requested due to automatic review settings February 10, 2026 21:45
@aduh95 aduh95 review requested due to automatic review settings February 10, 2026 21:46
@avivkeller avivkeller merged commit 264ce66 into main Feb 11, 2026
27 checks passed
@avivkeller avivkeller deleted the no-sort-changes branch February 11, 2026 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@avivkeller avivkeller avivkeller approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aduh95 @avivkeller